Add auto-update and improved validation for Block Layout#18
Merged
Conversation
Changes: - Remove manual "Update Visualization" button - Block Layout now auto-updates on input changes like Linear Layout - Add validation state tracking and button disable on validation errors - Fix parse error handling - decimals/NaN now show inline errors instead of throwing exceptions - Adopt LinearLayout's pattern: store NaN for invalid input and validate gracefully - Add smart validation short-circuiting to prevent confusing cascade errors - Add disabled button styling for better UX - Add comprehensive test coverage for new behavior Technical improvements: - ParameterForm.getNumberValue() returns NaN instead of throwing - ParameterForm.onParamsChange() replaces onSubmit for auto-update flow - ParameterForm.onValidationChange() enables reactive button state - InputValidator short-circuits derived checks when dependent fields are invalid - "Show in Linear Layout" button automatically disables when validation fails Tests: - Add ParameterForm.test.ts with decimal/NaN input coverage - Extend InputValidator.test.ts with parse error tests - Extend BlockLayoutTab.test.ts with validation button behavior tests - All 168 tests passing Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Technical improvements:
Tests: